feat: rate limiting #1290
Merged
feat: rate limiting #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 16, 2022
csviri
force-pushed
the
next
branch
2 times, most recently
from
b8b6b02 to
93c2b1b
Compare
metacosm
reviewed
Jul 4, 2022
| @@ -69,6 +69,9 @@ | |||
| ReconciliationMaxInterval reconciliationMaxInterval() default @ReconciliationMaxInterval( | |||
| interval = 10); | |||
|
|
|||
|
|
|||
| RateLimit rateLimit() default @RateLimit; | |||
There was a problem hiding this comment.
This will need to be fixed as this doesn't make any sense if users can provide their own RateLimiter implementations…
There was a problem hiding this comment.
The idea is that some can configure basic rate limit, what is usuabble in most of the cases. If the default implementation does not fit, configuration overrride still can be used.
Note that this is empty by default, so there is no default rate limiter.
metacosm
approved these changes
Jul 4, 2022
|
Kudos, SonarCloud Quality Gate passed! |
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
csviri
added a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.